Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): cover more cases of weird paths in vendir.yml configs #158

Merged
merged 4 commits into from
Dec 24, 2023

Conversation

Zebradil
Copy link
Member

@Zebradil Zebradil commented Dec 24, 2023

@kbudde was too quick with mering #156. This is a follow-up covering more cases.

@Zebradil Zebradil changed the title 155 myks 30 sync clean up regression fix(sync): cover more cases of weird paths in vendir.yml configs Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd6e41f) 48.18% compared to head (0157499) 48.30%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #158      +/-   ##
==========================================
+ Coverage   48.18%   48.30%   +0.12%     
==========================================
  Files          26       26              
  Lines        2447     2447              
==========================================
+ Hits         1179     1182       +3     
+ Misses       1085     1083       -2     
+ Partials      183      182       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zebradil Zebradil enabled auto-merge (squash) December 24, 2023 13:55
@Zebradil Zebradil merged commit 722ce01 into dev Dec 24, 2023
6 of 7 checks passed
@Zebradil Zebradil deleted the 155-myks-30-sync-clean-up-regression branch December 24, 2023 13:56
mykso-bot added a commit that referenced this pull request Dec 24, 2023
## [3.0.2](v3.0.1...v3.0.2) (2023-12-24)

### Bug Fixes

* **sync:** cover more cases of weird paths in vendir.yml configs ([#158](#158)) ([722ce01](722ce01))
* **sync:** trim path separator from vendir directories ([#156](#156)) ([7299eae](7299eae)), closes [#155](#155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant